test: mobile snapshots for page stories #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
codeincontext
changed the title
codeincontext
changed the title
codeincontext
force-pushed
the
test/chromatic-mobile-modes
branch
from
d6a4538 to
2c0d3f4
Compare
codeincontext
force-pushed
the
test/chromatic-mobile-modes
branch
from
2c0d3f4 to
3f6592d
Compare
mantagen
approved these changes
Dec 10, 2024
|
|
🎉 This PR is included in version 1.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #427
Description
This PR adds the mobile "mode" to the stories for full pages
We will do a separate investigation of any specific component stories which would benefit from a mobile snapshot
CHROMATIC_ALL_VIEWPORTS_COMPATmodes to all snapshots for pagesHow to test
Look at the chromatic page for this PR. There should be new mobile snapshots for each page, and they should look correct